Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mongodb): add db.operation span attribute #1321

Merged
merged 8 commits into from
Dec 11, 2022
Merged

feat(mongodb): add db.operation span attribute #1321

merged 8 commits into from
Dec 11, 2022

Conversation

haddasbronfman
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add db.operation attribute to span

@haddasbronfman haddasbronfman requested a review from a team December 6, 2022 14:20
@github-actions github-actions bot requested a review from osherv December 6, 2022 14:20
@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #1321 (58b8e8c) into main (f0a9368) will decrease coverage by 5.23%.
The diff coverage is 71.42%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   96.08%   90.84%   -5.24%     
==========================================
  Files          14       17       +3     
  Lines         893     1191     +298     
  Branches      191      267      +76     
==========================================
+ Hits          858     1082     +224     
- Misses         35      109      +74
Impacted Files Coverage Δ
...try-instrumentation-mongodb/src/instrumentation.ts 69.06% <71.42%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.21% <0.00%> (ø)
...etry-instrumentation-mongodb/src/internal-types.ts 100.00% <0.00%> (ø)

blumamir
blumamir reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM
Please add/update the tests for this new attribute :)

plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts Outdated Show resolved Hide resolved
@blumamir blumamir changed the title chore(mongo): add DB_OPERATION attribute chore(mongo): add db.operation span attribute Dec 7, 2022
@blumamir blumamir changed the title chore(mongo): add db.operation span attribute chore(mongodb): add db.operation span attribute Dec 7, 2022
@blumamir blumamir changed the title chore(mongodb): add db.operation span attribute feat(mongodb): add db.operation span attribute Dec 7, 2022
@blumamir blumamir merged commit 97305e1 into open-telemetry:main Dec 11, 2022
@dyladan dyladan mentioned this pull request Dec 11, 2022
Merged
@dyladan dyladan mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherv osherv osherv approved these changes

@blumamir blumamir blumamir approved these changes

Assignees

@osherv osherv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mongodb: add db.operation attribute
3 participants
@haddasbronfman @blumamir @osherv